Skip to content

fix(agents): merge divergent docs-writer duplicates, keep corrected facts#1849

Merged
steilerDev merged 1 commit into
betafrom
fix/1817-docs-writer-dedup
Jul 7, 2026
Merged

fix(agents): merge divergent docs-writer duplicates, keep corrected facts#1849
steilerDev merged 1 commit into
betafrom
fix/1817-docs-writer-dedup

Conversation

@steilerDev

@steilerDev steilerDev commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Two divergent copies of the docs-writer agent definition existed (docs-writer.md and cornerstone-docs-writer.md), causing skills to route to a stale, uncorrected definition.
  • Merges into a single docs-writer.md, keeping the corrected facts (site URL/baseUrl matching docs/docusaurus.config.js, .js config filenames, memory dir .claude/agent-memory/docs-writer/, Opus trailer convention matching other Opus agents, actual Docusaurus/React versions from docs/package.json) and deletes the stale duplicate.
  • Also sweeps in pending ux-designer agent-memory updates (PR refactor(client): consolidate Badge/Modal reuse, add shared hooks, trap modal focus #1848 review learnings) that were left uncommitted in the worktree from a prior batch item.

Fixes #1817

Test plan

  • Verified zero remaining references to cornerstone-docs-writer anywhere in the repo
  • Verified merged file's site URL/baseUrl against docs/docusaurus.config.js
  • Verified config filenames (.js not .ts) and versions against docs/package.json
  • Verified Co-Authored-By trailer convention matches product-architect.md/product-owner.md
  • Verified skills (review-pr, release) already reference docs-writer, not the deleted duplicate
  • Agent-config only change — no production code, no tests needed
  • Quality Gates CI

Co-Authored-By: Claude dev-team-lead (Sonnet 4.6) noreply@anthropic.com

@steilerDev @claude
fix(agents): merge divergent docs-writer duplicates, keep corrected f…
26097be 
…acts

Two divergent copies of the docs-writer agent existed (docs-writer.md and
cornerstone-docs-writer.md), causing skills to route to a stale definition.
Merges them into a single docs-writer.md with facts verified against the
repo (site URL/baseUrl, .js config filenames, memory dir path, Opus trailer
convention, actual Docusaurus/React versions) and removes the duplicate.

Fixes #1817

Co-Authored-By: Claude dev-team-lead (Sonnet 4.6) <noreply@anthropic.com>
@steilerDev

steilerDev commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

[security-engineer] Security review — agent-config only PR, quick pass.

Scope confirmed: .claude/agents/docs-writer.md (merged), .claude/agents/cornerstone-docs-writer.md (deleted), plus .claude/agent-memory/ux-designer/MEMORY.md and pr-review-findings.md (leftover uncommitted notes from PR #1848 review, explicitly disclosed in the PR description). No server/, client/, or shared/ files touched.

Agent definition review (docs-writer.md):

  • No prompt-injection-shaped content, no instructions to bypass review/CI, no instructions to push directly to main/beta — the merged Git Workflow section explicitly reiterates "Never commit directly to main or beta" and routes through feature branch + PR + CI gate polling, consistent with CLAUDE.md.
  • The one force-push reference (line 281) is scoped to "rebase onto beta after a CONFLICTING mergeability check, then force-push the feature branch" — not main/master — consistent with repo convention, not a red flag.
  • No hardcoded credentials, tokens, API keys, or secret-handling instructions anywhere in the file.
  • No eval/exec/curl-to-shell patterns or other supply-chain-style injection vectors.

Deleted file (cornerstone-docs-writer.md, 309 lines removed): diffed side-by-side against the merged result — it was a near-duplicate agent definition (same protected-README constraint, same branching rules, same quality checklist). Nothing security-relevant (auth, secrets, access-control, or safety guidance) existed in the deleted copy that isn't preserved in the surviving docs-writer.md. This is a straightforward dedup, not a loss of guardrails.

Verdict: APPROVED

@steilerDev steilerDev merged commit 91be98c into beta Jul 7, 2026
12 checks passed
@steilerDev steilerDev deleted the fix/1817-docs-writer-dedup branch July 7, 2026 23:01
@steilerDev steilerDev mentioned this pull request Jul 7, 2026
Closed
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.13.0-beta.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@steilerDev